Merged
Conversation
Put commit ref in external file. Update all static files for new build.
github-actions
bot
added
DEV: dev-ops
Contributor
Build Artifacts
|
rtibbles
force-pushed
the
auto_update_h5p
branch
from
441a7df to
e7cbb0f
Compare
Member
Author
|
I have converted this to a draft for now, we can test this action out on the test-actions repository first to avoid too much iteration here. |
rtibbles
force-pushed
the
auto_update_h5p
branch
from
e7cbb0f to
33bd170
Compare
rtibbles
force-pushed
the
auto_update_h5p
branch
from
33bd170 to
5bc3d41
Compare
Member
Author
|
Did some testing on the test-actions repo to refine this, this should now be ready to go. See example PR there: learningequality/test-actions#45 |
| print("No stored commit found, treating as new") | ||
| has_changed = True | ||
| # Set outputs for GitHub Actions | ||
| with open(os.environ['GITHUB_OUTPUT'], 'a') as f: |
Member
There was a problem hiding this comment.
I love all of this injected Python stuff, but this in particular is really neat to write to the env var as a file to speak to the GH action runner.
nucleogenesis
approved these changes
Dec 21, 2024
Member
nucleogenesis
left a comment
nucleogenesis
left a comment
There was a problem hiding this comment.
I've given this a look and see nothing blocking so should be good to merge & test
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reviewer guidance
This is an experiment to try to give dependabot regularity updating to our H5P bundled code.
If this works, we can try something similar for Bloom Reader - but that will be a little more involved, as we will have to update our fork of it as well.
The best way to test this will be to merge and run the action manually - so the main thing to look for here is that the updated files make sense, and that the action doesn't have any obvious flaws.
Testing checklist
PR process
Reviewer checklist
yarnandpip)